Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies in the Blake2s implementation #108

Open
ii-cruz opened this issue Feb 17, 2023 · 1 comment
Open

Inconsistencies in the Blake2s implementation #108

ii-cruz opened this issue Feb 17, 2023 · 1 comment

Comments

@ii-cruz
Copy link

ii-cruz commented Feb 17, 2023

On #103 the parameters function was removed from the Blake2sWithParameterBlock. However, for prf::blake2s::constraints::evaluate_blake2s_with_parameters, we need the parameters formatted as [u32; 8] as an argument, which would be exposed by calling the removed function.

Additionally, the non-constraint evaluate function now only runs in Mac mode. Even if no key is provided, a full 0-padded block is prefixed. This is different from the constraint behavior.

@paberr
Copy link

paberr commented Feb 17, 2023

Moreover, the change in the Blake2sWithParameterBlock struct removed the possibility to run the Blake2X algorithm for an extensible-output function.

To be fair, it seems that the blake2 crate doesn't support XOFs anymore.
The constraint implementation technically still supports it with a custom parameter block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants