Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PoseidonXYZ types in poseidon module. #94

Open
4 tasks
hdevalence opened this issue Sep 30, 2021 · 0 comments
Open
4 tasks

Rename PoseidonXYZ types in poseidon module. #94

hdevalence opened this issue Sep 30, 2021 · 0 comments

Comments

@hdevalence
Copy link

Summary

Rename the PoseidonParams, PoseidonSponge, PoseidonSpongeState types to Params, Sponge, SpongeState, respectively.

Problem Definition

This avoids repeating the word "poseidon" and gives the API user choice of how to name the types. In a context where it's important to specify that it's a Poseidon sponge, they can use poseidon; and refer to poseidon::Sponge; in a context where it's clear, they can simply use poseidon::Sponge; and refer to Sponge.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@Pratyush Pratyush transferred this issue from arkworks-rs/sponge Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant