Skip to content
This repository has been archived by the owner on May 18, 2023. It is now read-only.

Latency over time - median value displayed for p95 and p99 #7

Open
foliv57 opened this issue Feb 22, 2022 · 5 comments
Open

Latency over time - median value displayed for p95 and p99 #7

foliv57 opened this issue Feb 22, 2022 · 5 comments

Comments

@foliv57
Copy link

foliv57 commented Feb 22, 2022

Hi,

I'm using the latest version of report viewer and, for some reason, in the "Latency over time" graphic, the p95 and p99 lines are both displaying the median value.

image

image

Attached the JSON report.

Thank you
report.zip
@cfryerdev
Copy link
Contributor

cfryerdev commented Mar 25, 2022 •
edited
Loading

Yeah, looks like a bad paste in graph_latency.jsx on lines 53 and 60. PR is open to resolve this.

cfryerdev added a commit to cfryerdev/report-viewer that referenced this issue Mar 25, 2022
@cfryerdev
fixed bug artilleryio#7 latency over time showing only median for p s…
85ce3d3 
…cores
@cfryerdev
Copy link
Contributor

I have a PR open for this fix, waiting for an approval.

hassy added a commit that referenced this issue Apr 19, 2022
@hassy
Merge pull request #9 from cfryerdev/fix/latency-over-time
da77464 
fixed bug #7 latency over time showing only median for p scores
@cfryerdev
Copy link
Contributor

@foliv57 can you verify now that you are seeing the correct values? After which we can close this issue, thanks a ton for letting me know!

@foliv57
Copy link
Author

foliv57 commented Apr 20, 2022

Hi @cfryerdev ,

I confirm that the change fixed the issue.
image

Thank you for this fix

@cfryerdev
Copy link
Contributor

Excellent. @hassy can close this bug.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cfryerdev @foliv57