Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate improvement in JSON huge payload #1993

Open
sebastienros opened this issue Jun 3, 2024 · 4 comments
Open

Investigate improvement in JSON huge payload #1993

sebastienros opened this issue Jun 3, 2024 · 4 comments
Assignees
@BrennanConroy

Comments

@sebastienros
Copy link
Member

image
@sebastienros sebastienros mentioned this issue Jun 3, 2024
Open
@BrennanConroy
Copy link
Member

Narrowed this down to dotnet/runtime@8f2f3da...010a744
Which is the Json change that shouldn't really affect too much yet 😆

@sebastienros
Copy link
Member Author

But it's also regression workingset/allocations, is that expected? #1994

@BrennanConroy
Copy link
Member

Haven't looked at that one yet.

@BrennanConroy
Copy link
Member

Allocations are all from PooledByteBufferWriter. I think we basically doubled the size of it by adding a Stream field to it, and making it inherit from PipeWriter which has a private Stream field as well. So it went from int and byte[], to int, byte[], Stream, Stream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrennanConroy BrennanConroy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastienros @BrennanConroy