Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate DataStore with CV ontologies #840

Open
mylibrar opened this issue Jun 23, 2022 · 0 comments · May be fixed by #844
Open

Integrate DataStore with CV ontologies #840

mylibrar opened this issue Jun 23, 2022 · 0 comments · May be fixed by #844

Comments

@mylibrar
Copy link
Collaborator

mylibrar commented Jun 23, 2022

Is your feature request related to a problem? Please describe.

  • We should integrate all the top-level Entrys to DataStore. Currently the following ontologies have not beed integrated yet:
    • ImageAnnotation
    • Region
    • Box
    • BoundingBox
  • We also need to formalize the steps to add a new top level entry. A more details guide should be created for developers to follow when they want to register a new entry in top.py.

Depends on

Describe the solution you'd like

  • To migrate a top-level Entry, we will need to
    • Design a schema for it in DataStore
      • The schema should only consists of primitive types or built-in list/dict. We want it to be serializable.
      • For example, a Group type should store its <member_type> and <[members_tid_list]> as the first two attributes in DataStore.
    • Update DataStore._add_entry_raw to include the new entry
    • Direct all the update operations to DataStore
      • When we call Group.add_member(entry), under the hood it should append entry.tid to the member list stored in DataStore.

Describe alternatives you've considered
It's better to include some dedicated test cases to validate any corner cases.

Additional context

  • This is part of the data efficiency project
  • This PR should be made to the master branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant