Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read audio with specific sampling rate and option for mixdown #110

Closed
frankenjoe opened this issue Feb 1, 2023 · 2 comments · Fixed by #114
Closed

Read audio with specific sampling rate and option for mixdown #110

frankenjoe opened this issue Feb 1, 2023 · 2 comments · Fixed by #114

Comments

@frankenjoe
Copy link
Collaborator

Some libraries offer the option to set a target rate when reading an audio file, see e.g. librosa.load(). I wonder if we should also give the user the option to request a specific sampling rate and maybe also the option for a mixdown using our audresample package. This could be quite convenient for users not aware of aware of audresample .

@hagenw
Copy link
Member

hagenw commented Feb 1, 2023

I'm not really in favor of adding a dependency to audresample to audiofile. This was also the reason why I closed #108.

At the moment I see two issues with audresample:

As an alternative solution I would propose that we extend the usage documentation, and maybe even the docstring examples of audiofile.read() with examples how to use audresample to resample and/or mix the returned signal.

@frankenjoe
Copy link
Collaborator Author

Yes, those are indeed two strong arguments for avoiding the dependency, though users who don't care much about dependencies may prefer librosa.load() if they want to resample. But I guess that's ok. At least extending the docstring seems like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants