You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The linkability function in the audmetric module has undergone a simplification of its type hints for the truth and prediction parameters. While this change aims to improve readability, there is a concern about whether it maintains the same level of type safety and does not alter the function's behavior or expected input types.
Additionally, it has been observed that calling audmetric.linkability(True, True) results in a TypeError with the message: "iteration over a 0-d array". This indicates a potential issue with handling scalar types in the function.
Currently, there are no tests for scalar types in test_linkability, which could help in identifying and resolving this issue.
Action Items:
Review the simplification of type hints to ensure type safety and correct behavior.
Investigate the TypeError when scalar types are used as inputs.
Add tests for scalar types in test_linkability to prevent similar issues in the future.
The
linkability
function in theaudmetric
module has undergone a simplification of its type hints for thetruth
andprediction
parameters. While this change aims to improve readability, there is a concern about whether it maintains the same level of type safety and does not alter the function's behavior or expected input types.Additionally, it has been observed that calling
audmetric.linkability(True, True)
results in aTypeError
with the message: "iteration over a 0-d array". This indicates a potential issue with handling scalar types in the function.Currently, there are no tests for scalar types in
test_linkability
, which could help in identifying and resolving this issue.Action Items:
TypeError
when scalar types are used as inputs.test_linkability
to prevent similar issues in the future.I created this issue for @ChristianGeng from #60 (comment).
Tips and commands
Interacting with Sourcery
@sourcery-ai plan
on this issue.@sourcery-ai develop
togenerate a PR that addresses this issue.
Getting Help
As mentioned below, the scope of the MR should be extended:
_matching_scores
has the same problem and should be extended analogouslyThe text was updated successfully, but these errors were encountered: