Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Library Log File" Grows With No Limit (2.0) #171

Open
winzig opened this issue Aug 17, 2021 · 8 comments
Open

"Library Log File" Grows With No Limit (2.0) #171

winzig opened this issue Aug 17, 2021 · 8 comments
Labels
feature-request A feature should be added or improved. module/logging p2 This is a standard priority issue queued

Comments

@winzig
Copy link

winzig commented Aug 17, 2021

As requested, opening this ticket that was previously closed prematurely to re-report this issue.

The issue: if there is a problem preventing the logs from being able to be sent to CloudWatch, the aws-logger-errors.txt file will be filled and grow with no bounds, eventually filling the disk.

As sattpat replied back in 2019:

We certainly dont want to be logging every single issue. We would instead like to capture exceptions that are unique. Meaning that if you get exceptions as a result of network connection, we only log that once and we skip the repeats.

This seems like a very good solution. Perhaps whatever is logging to aws-logger-errors.txt could keep track of recently written errors, and if it's logging the same error several times in a row, it logs an additional "This issue won't be logged again until the process is restarted", and then stops logging that same error again.

@winzig winzig added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Aug 17, 2021
@ashishdhingra ashishdhingra added module/logging and removed needs-triage This issue or PR still needs to be triaged. labels Aug 17, 2021
@ashishdhingra
Copy link
Contributor

@winzig Thanks for opening the issue. I'm not sure if logging specific issue only once is feasible. But I will discuss with the team and post any updates here.

@normj
Copy link
Member

normj commented Aug 19, 2021

I think the solution would need to be a bit more sophisticated then that. If we stop logging how does a user know if the problem is still happening or if the process has recovered. So we would need something where we detect we are continually getting problems and if so write that there have been constant failures and they will no longer be written out. And if the failures have stopped we would need to write that the system has corrected itself.

@normj
Copy link
Member

normj commented Aug 19, 2021

Or would it just be easier and sufficient to implement a simple rolling log file approach with a max number of files?

@winzig
Copy link
Author

winzig commented Aug 19, 2021

@normj Yeah that would be a great solution I think!

@ashishdhingra ashishdhingra added feature-request A feature should be added or improved. and removed bug This issue is a bug. labels Aug 20, 2021
@Alex6015
Copy link

Hi,
Any updates on this issue?
we didnt noticed and one of our servers reached 66GB aws-logger-errors.txt file size

@github-actions
Copy link

We have noticed this issue has not received attention in over a year. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Nov 15, 2022
@winzig
Copy link
Author

winzig commented Nov 15, 2022

I think this should remain open unless @normj's recommendation of a rolling log file approach has been implemented in the last year?

@ashovlin ashovlin removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Nov 15, 2022
@ashishdhingra ashishdhingra added the p2 This is a standard priority issue label Dec 14, 2022
@udlose
Copy link

udlose commented Apr 14, 2023

Any updates on getting this fixed? My ECS Containers are out of space because of this error...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. module/logging p2 This is a standard priority issue queued
Projects
None yet
Development

No branches or pull requests

6 participants