Assembly Version not updated on DLLs

[AlexAtEF]

Describe the bug

The assembly version has not been updated since version 3.3, which causes "conflicts" about which version is needed, because newer packages have dependencies on a newer Core version.

Consider this example for my project with AWSSDK.Core.3.7.201.2, AWSSDK.EventBridge.3.7.102.33, and AWSSDK.SecurityToken.3.7.103.12, but still produces this message:

There was a conflict between "AWSSDK.Core, Version=3.3.0.0, Culture=neutral, PublicKeyToken=885c28607f98e604" and "AWSSDK.Core, Version=3.7.0.0, Culture=neutral, PublicKeyToken=885c28607f98e604".
    "AWSSDK.Core, Version=3.3.0.0, Culture=neutral, PublicKeyToken=885c28607f98e604" was chosen because it was primary and "AWSSDK.Core, Version=3.7.0.0, Culture=neutral, PublicKeyToken=885c28607f98e604" was not.
    References which depend on "AWSSDK.Core, Version=3.3.0.0, Culture=neutral, PublicKeyToken=885c28607f98e604" [C:\BuildAgent\work\51a5881dfc0f5f14\packages\AWSSDK.Core.3.7.201.2\lib\net45\AWSSDK.Core.dll].
        C:\BuildAgent\work\51a5881dfc0f5f14\packages\AWSSDK.Core.3.7.201.2\lib\net45\AWSSDK.Core.dll
          Project file item includes which caused reference "C:\BuildAgent\work\51a5881dfc0f5f14\packages\AWSSDK.Core.3.7.201.2\lib\net45\AWSSDK.Core.dll".
            AWSSDK.Core, Version=3.3.0.0, Culture=neutral, PublicKeyToken=885c28607f98e604, processorArchitecture=MSIL
    References which depend on "AWSSDK.Core, Version=3.7.0.0, Culture=neutral, PublicKeyToken=885c28607f98e604" [].
        C:\BuildAgent\work\51a5881dfc0f5f14\packages\AWSSDK.EventBridge.3.7.102.33\lib\net45\AWSSDK.EventBridge.dll
          Project file item includes which caused reference "C:\BuildAgent\work\51a5881dfc0f5f14\packages\AWSSDK.EventBridge.3.7.102.33\lib\net45\AWSSDK.EventBridge.dll".
            AWSSDK.EventBridge, Version=3.3.0.0, Culture=neutral, PublicKeyToken=885c28607f98e604, processorArchitecture=MSIL
        C:\BuildAgent\work\51a5881dfc0f5f14\packages\AWSSDK.SecurityToken.3.7.103.12\lib\net45\AWSSDK.SecurityToken.dll
          Project file item includes which caused reference "C:\BuildAgent\work\51a5881dfc0f5f14\packages\AWSSDK.SecurityToken.3.7.103.12\lib\net45\AWSSDK.SecurityToken.dll".
            AWSSDK.SecurityToken, Version=3.3.0.0, Culture=neutral, PublicKeyToken=885c28607f98e604, processorArchitecture=MSIL

Inspecting the latest core with powershell shows the dll thinks its version 3.3.0.0

PS C:\> $assembly = [System.Reflection.Assembly]::LoadFrom("AWSSDK.Core.3.7.201.2\lib\net45\AWSSDK.Core.dll")
PS C:\> $assembly.FullName
AWSSDK.Core, Version=3.3.0.0, Culture=neutral, PublicKeyToken=885c28607f98e604

Expected Behavior

The DLL should report its version 3.7

PS C:\Users\AlexWeingarten> $assembly = [System.Reflection.Assembly]::LoadFrom("AWSSDK.Core.3.7.201.2\lib\net45\AWSSDK.Core.dll")
PS C:\Users\AlexWeingarten> $assembly.FullName
AWSSDK.Core, Version=3.7.0.0, Culture=neutral, PublicKeyToken=885c28607f98e604

Current Behavior

It reports its 3.3

PS C:\> $assembly = [System.Reflection.Assembly]::LoadFrom("AWSSDK.Core.3.7.201.2\lib\net45\AWSSDK.Core.dll")
PS C:\> $assembly.FullName
AWSSDK.Core, Version=3.3.0.0, Culture=neutral, PublicKeyToken=885c28607f98e604

Reproduction Steps

Download package, inspect with powershell as demonstrated above

Possible Solution

Remove OverrideCoreVersion?

aws-sdk-net/generator/ServiceModels/_sdk-versions.json

Line 5 in b7a9a11

"OverrideCoreVersion" : "3.3",

Additional Information/Context

No response

AWS .NET SDK and/or Package version used

AWSSDK.Core.3.7.201.2
AWSSDK.EventBridge.3.7.102.33
AWSSDK.SecurityToken.3.7.103.12

Targeted .NET Platform

.Net Framework 4.8

Operating System and version

Windows 11

[ashishdhingra]

@AlexAtEF Good morning. Thanks for opening the issue. This is as per design. We only update the file version. CC @normj for providing more details about design considerations.

Converting this into discussion since this is not an issue.

[normj]

In you conflict example I'm confused how you ever had an assembly version of 3.7.0.0 of Core to conflict with. As you know the assembly version has been locked at 3.3.0 for a very long time, 2015 I think. That version represents the last time we made breaking changes that required users to recompile.

The reason we leave the assembly version at 3.3.0.0 is since we strong name the assemblies which includes the assembly version that means at least for .NET Framework versions they need to recompile their application every time we release a new version which is a lot given our release cycle. If it was just recompile the application that would probably be okay but the scenarios where the SDK is brought in as a transitive dependency and rebuilding the dependency is not feasible this breaks a lot of users. We used to change the assembly version with every release and it caused a lot of friction once the release cycle of AWS speed up so frequently.

I can't remember with modern .NET/.NET Core if the version number is part of the identity of the assembly. That is worth investigating if it is not and if not would be possible to update the assembly version for the .NET Core version of the SDK.

@github-actions proposed-answer

[github-actions[bot]]

Hello! A team member has marked the above comment as the likely answer to this discussion thread.

• If you agree, please upvote that comment, or click on Mark as answer. I will automatically mark the comment as the answer next time I check.

• If this answer does not help you, please downvote the answer instead and let us know why it was not helpful. I will add a label to this discussion to gain attention from the team.

[github-actions[bot]]

Hello! Reopening this discussion to make it searchable.