Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically flush for Log Event > 256KB #32

Open
jchangxu opened this issue Apr 22, 2020 · 1 comment
Open

Automatically flush for Log Event > 256KB #32

jchangxu opened this issue Apr 22, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@jchangxu
Copy link

According to https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Embedded_Metric_Format_Specification.html
The embedded metric format is subject to the same limits as standard CloudWatch Logs events and are limited to a maximum size of 256 KB.

It would be really nice to have an auto flush feature when we detect the serialized log event is near 256KB.

@jaredcnance
Copy link
Member

jaredcnance commented Apr 23, 2020

This one is interesting because we don’t know the size until we serialize it. We could maintain a character counter on insertion, but it may not be very accurate and will have lots of edge cases. Need to think about this one a bit. It might be easier to provide a configurable “flush after” metric count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants