Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect representation of empty prereqs in Master #1

Open
AbdallahS opened this issue Nov 1, 2021 · 0 comments
Open

Incorrect representation of empty prereqs in Master #1

AbdallahS opened this issue Nov 1, 2021 · 0 comments

Comments

@AbdallahS
Copy link

The representation of Prereqs in a Course object is a list of list of courses in DNF (a disjunction of conjunction of other courses). If a course has no actual prerequisite courses, then we should represent this with the list [[]] (a disjunction of an empty conjunction). That way, the empty conjunction is trivially true, so the disjunction holds and we can see that the prereqs for the course are satisfied.

In Master, this is currently represented as [] (instead of [[]]) so trivially false instead of trivially true. Not sure if it's been addressed in the banches, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant