Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🙉 Breaking Changes #37

Closed
axieax opened this issue Sep 19, 2022 · 4 comments
Closed

🙉 Breaking Changes #37

axieax opened this issue Sep 19, 2022 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@axieax
Copy link
Owner

axieax commented Sep 19, 2022

Subscribe to this thread for breaking changes and resolutions

Repository owner locked as spam and limited conversation to collaborators Sep 19, 2022
@axieax axieax pinned this issue Sep 19, 2022
@axieax
Copy link
Owner Author

axieax commented Sep 19, 2022

Commit f91b831 / PR #36

Breaking Changes

Breaking changes have been introduced during refactoring for the actions module, deprecating config.navigate_method for config.default_action.

Resolution

Simply rename the "navigate_method" key in the config passed to urlview.setup to be "default_action".

You can also set an action each time with something like :UrlView buffer action=clipboard or :UrlView buffer action=chromium.

@axieax axieax added the documentation Improvements or additions to documentation label Sep 19, 2022
@axieax

This comment was marked as off-topic.

@axieax axieax closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2022
@axieax
Copy link
Owner Author

axieax commented Sep 25, 2022

PR #38

Breaking Changes

The config option debug (boolean) has been deprecated for log_level_min (vim.log.levels integer) to allow users to more finely control the level of log messages they want to see.

Resolution

Remove the debug option from your config and optionally add a log_level_min key, specifying a vim.log.levels enum like in the README. By default, this is vim.log.levels.INFO, which contains some additional info warnings, but it is recommended for this to be at least vim.log.levels.WARN to capture important warnings.

@axieax
Copy link
Owner Author

axieax commented Oct 5, 2022

PR #39

Breaking Changes

  1. Deprecate support for Neovim v0.6.
  2. Separate config option custom_searches from setup.

Resolution

  1. Please update your Neovim version to v0.7 or later, or use the v0.6-compat tag to be able to continue using this plugin but no longer receive updates.
  2. Please use require("urlview.search.helpers").generate_custom_search to register custom searches. Further details can be found in the new documentation under urlview.search-custom.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant