Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of packages to Python 3 #175

Open
argenos opened this issue May 25, 2019 · 8 comments
Open

Migration of packages to Python 3 #175

argenos opened this issue May 25, 2019 · 8 comments
Labels
Type: Maintenance Changes due to version updates or CI setup Type: Refactoring Changes in the way the code works internally.

Comments

@argenos
Copy link
Contributor

argenos commented May 25, 2019

No description provided.

@argenos argenos added Type: Maintenance Changes due to version updates or CI setup Type: Refactoring Changes in the way the code works internally. labels May 25, 2019
@argenos argenos pinned this issue May 26, 2019
@alex-mitrevski
Copy link
Member

alex-mitrevski commented Jun 15, 2019

I can't recall if there was a discussion about this, but I think we should treat this issue independent of the Melodic migration for the time being. Because of ROPOD, we cannot (fully) migrate to Melodic now (i.e. we need our development machines to have Ubuntu 16.04/ROS kinetic), but most of the code can be migrated to Python 3 anyway since ROS kinetic works fine with Python 3 (with the exception of a few packages that need some fixing, notably mongodb_store and tf2).

@argenos
Copy link
Contributor Author

argenos commented Jun 15, 2019 via email

@alex-mitrevski
Copy link
Member

I’m just not sure what the current issues are of setting up kinetic with python 3

As I said, I've only had problems with a few packages (I forgot to mention OpenCV in the above list, which is also problematic); everything else is working fine with Python 3.

What about using docker?

You mean docker for melodic, right?

@argenos
Copy link
Contributor Author

argenos commented Jun 18, 2019

I’m just not sure what the current issues are of setting up kinetic with python 3

As I said, I've only had problems with a few packages (I forgot to mention OpenCV in the above list, which is also problematic); everything else is working fine with Python 3.

Alright, based on that we would need:

What about using docker?

You mean docker for melodic, right?

Yes, we (the staff) could use docker for melodic. The rest can upgrade or have a bionic partition.

@minhnh
Copy link
Member

minhnh commented Jun 18, 2019

In general, OpenCV shouldn't be an issue. The big change was indigo->kinetic since they went from OpenCV 2 to 3. kinetic->melodic is just OpenCV 3. I haven't got a chance to add tests for cv_bridge, however.

@argenos
Copy link
Contributor Author

argenos commented Jun 18, 2019

I reopened #176 and updated it to kinetic, and I can take care of it once someone creates the script.

@alex-mitrevski
Copy link
Member

@minhnh I was referring to Python 3 on kinetic when I said there are problems with OpenCV; kinetic to melodic might not be a problem.

@argenos argenos unpinned this issue Oct 2, 2019
@argenos
Copy link
Contributor Author

argenos commented Oct 14, 2019

FWIW, on an unrelated test, I ended up having to test something with opencv and python3. cv_bridge needs to be built with python3, e.g. see here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Changes due to version updates or CI setup Type: Refactoring Changes in the way the code works internally.
Projects
None yet
Development

No branches or pull requests

7 participants