Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mir_perception_utils] Chaning header of a const pointcloud. #258

Open
2 tasks done
vamsikalagaturu opened this issue Sep 23, 2022 · 0 comments
Open
2 tasks done

Comments

@vamsikalagaturu
Copy link
Contributor

Describe the bug

  • transformPointCloudMsg and transformPointCloud methods changes the pointcloud_in header value, which is a const variable. Therefore, the build throws a warning.

Steps to Reproduce

  1. Build the mir_perception_utils package

Expected Behavior

The below warnings will occur:

warning: passing ‘const _stamp_type’ {aka ‘const ros::Time’} as ‘this’ argument discards qualifiers [-fpermissive]
   23 |       cloud_in.header.stamp = common_time;
warning: passing ‘const pcl::PCLHeader’ as ‘this’ argument discards qualifiers [-fpermissive]
   51 |       cloud_in.header = pc_header;

Environment

  • Version used (branch/commit):
  • PC:
    • on the robot (YBRSU-2)
  • build command:
    • catkin build --this (mir_perception_utils)

Suggested fix

  • Convert the variable from const to not const and modify all subsequent function declarations.
@deebuls deebuls added this to the Bordeaux milestone Feb 15, 2023
@vamsikalagaturu vamsikalagaturu removed this from the Bordeaux milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants