Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate configuration early #133

Open
Regenhardt opened this issue Apr 19, 2024 · 4 comments
Open

Validate configuration early #133

Regenhardt opened this issue Apr 19, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Regenhardt
Copy link

Options injected from the configuration like db and storage are validated when they are requested. This means, configuration for storage are only validated when a package is pushed or downloaded, as that is when the options object is first requested.

That's not great for setup when you don't 100% know what you're doing. I'd like either something calling all validations on startup, or on the statistics page.

Statistics page is probably better as this might run in a container somewhere and this way it can be spun up and looked at without having to go find the infrastructure's logs.

So I guess instead of the current service list, there'll be a table like this:

Database Storage Search Mirror
PostgreSql S3 DB integrated None
-
Region not set

Opinions?

@Regenhardt Regenhardt added the enhancement New feature or request label Apr 19, 2024
@Regenhardt
Copy link
Author

With borders:
grafik

Without borders:
grafik

@seriouz
Copy link

seriouz commented Apr 25, 2024

I like the idea of a table but i would pivot it:

Service Info Health Message
Database Postgres No errors
Storage AwS3 Error Message here
Cache - Not configured
Search Database No errors

@Regenhardt
Copy link
Author

I chose a column per service because there may be multiple error messages for a config and that would change the height of the whole row, while the number of services will always be the same. Having all errors in the last row would just expand that one, leaving the rest of the table alone.
I do like the health status neatly below each other though.

@ferarias
Copy link

ferarias commented May 2, 2024

if you ask me, I like more the compact look of a row for each service, but both will do the job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants