Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupytext does not exist for automated tests #89

Closed
sklbancor opened this issue Aug 25, 2023 · 0 comments · Fixed by #93
Closed

Jupytext does not exist for automated tests #89

sklbancor opened this issue Aug 25, 2023 · 0 comments · Fixed by #93
Assignees
Labels
bug Something isn't working

Comments

@sklbancor
Copy link
Collaborator

sklbancor commented Aug 25, 2023

This is the run_tests.py that runs the tests

Screenshot 2023-08-25 at 12 53 22

That's how it looks like when it runs on Github (suggesting JupyText is not available)

Screenshot 2023-08-25 at 12 55 32

In other words -- unless someone does run_tests on the local machine first, NBTests will not be converted into .py tests AND THEREFORE THOSE TESTS WILL NOT RUN ON THE SERVER, EVEN THOUGH IT LOOKS LIKE THEY DO.

This is obviously dangerous and should be rectified.

@sklbancor sklbancor added the bug Something isn't working label Aug 25, 2023
@mikewcasale mikewcasale linked a pull request Aug 28, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants