From 39115b9e24731c8a5bd98e5d0e86834303b3ed85 Mon Sep 17 00:00:00 2001 From: Fabian Meumertzheim Date: Wed, 8 May 2024 10:35:57 -0700 Subject: [PATCH] Replace `INFO` with `FINE` logging in `CoverageOutputGenerator` This reduces unconditional log spam for coverage report actions. If needed, users can configure the loglevel by wrapping the `CoverageOutputGenerator` jar into a `java_binary` with appropriate `jvmopts`. Closes #22257. PiperOrigin-RevId: 631849225 Change-Id: I3c656216b81f6a5920edf46e7ae1b8afe970faef --- .../devtools/coverageoutputgenerator/Main.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tools/test/CoverageOutputGenerator/java/com/google/devtools/coverageoutputgenerator/Main.java b/tools/test/CoverageOutputGenerator/java/com/google/devtools/coverageoutputgenerator/Main.java index cd229666134244..3cd33ceb34d27b 100644 --- a/tools/test/CoverageOutputGenerator/java/com/google/devtools/coverageoutputgenerator/Main.java +++ b/tools/test/CoverageOutputGenerator/java/com/google/devtools/coverageoutputgenerator/Main.java @@ -217,9 +217,9 @@ private static boolean isMetadataFile(String filename) { private static List getGcovInfoFiles(List filesInCoverageDir) { List gcovFiles = getFilesWithExtension(filesInCoverageDir, GCOV_EXTENSION); if (gcovFiles.isEmpty()) { - logger.log(Level.INFO, "No gcov info file found."); + logger.log(Level.FINE, "No gcov info file found."); } else { - logger.log(Level.INFO, "Found " + gcovFiles.size() + " gcov info files."); + logger.log(Level.FINE, "Found " + gcovFiles.size() + " gcov info files."); } return gcovFiles; } @@ -227,9 +227,9 @@ private static List getGcovInfoFiles(List filesInCoverageDir) { private static List getGcovJsonInfoFiles(List filesInCoverageDir) { List gcovJsonFiles = getFilesWithExtension(filesInCoverageDir, GCOV_JSON_EXTENSION); if (gcovJsonFiles.isEmpty()) { - logger.log(Level.INFO, "No gcov json file found."); + logger.log(Level.FINE, "No gcov json file found."); } else { - logger.log(Level.INFO, "Found " + gcovJsonFiles.size() + " gcov json files."); + logger.log(Level.FINE, "Found " + gcovJsonFiles.size() + " gcov json files."); } return gcovJsonFiles; } @@ -241,7 +241,7 @@ private static List getGcovJsonInfoFiles(List filesInCoverageDir) { private static File getProfdataFileOrNull(List files) { List profdataFiles = getFilesWithExtension(files, PROFDATA_EXTENSION); if (profdataFiles.isEmpty()) { - logger.log(Level.INFO, "No .profdata file found."); + logger.log(Level.FINE, "No .profdata file found."); return null; } if (profdataFiles.size() > 1) { @@ -252,7 +252,7 @@ private static File getProfdataFileOrNull(List files) { + " .profadata files were found instead."); return null; } - logger.log(Level.INFO, "Found one .profdata file."); + logger.log(Level.FINE, "Found one .profdata file."); return profdataFiles.get(0); } @@ -264,9 +264,9 @@ private static List getTracefiles(LcovMergerFlags flags, List filesI lcovTracefiles = getFilesWithExtension(filesInCoverageDir, TRACEFILE_EXTENSION); } if (lcovTracefiles.isEmpty()) { - logger.log(Level.INFO, "No lcov file found."); + logger.log(Level.FINE, "No lcov file found."); } else { - logger.log(Level.INFO, "Found " + lcovTracefiles.size() + " tracefiles."); + logger.log(Level.FINE, "Found " + lcovTracefiles.size() + " tracefiles."); } return lcovTracefiles; } @@ -310,7 +310,7 @@ static Coverage parseFilesSequentially(List files, Parser parser) { Coverage coverage = new Coverage(); for (File file : files) { try { - logger.log(Level.INFO, "Parsing file " + file); + logger.log(Level.FINE, "Parsing file " + file); List sourceFilesCoverage = parser.parse(new FileInputStream(file)); for (SourceFileCoverage sourceFileCoverage : sourceFilesCoverage) { coverage.add(sourceFileCoverage);