From 3921bde3639affc7f0d177014a983c8ea7e3f44f Mon Sep 17 00:00:00 2001 From: Fabian Meumertzheim Date: Thu, 5 Sep 2024 11:25:18 -0700 Subject: [PATCH] Deduplicate calls to `config.is_sibling_repository_layout()` This showed up in Starlark CPU profiles and is not negligible as it repeatedly checks allowlists. Closes #23256. PiperOrigin-RevId: 671444687 Change-Id: I6e64b0c94332a54fcc5d531ff0e3aab176b7bd0a --- .../builtins_bzl/common/cc/cc_compilation_helper.bzl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/starlark/builtins_bzl/common/cc/cc_compilation_helper.bzl b/src/main/starlark/builtins_bzl/common/cc/cc_compilation_helper.bzl index 1177edbbd71630..b0c7513adc5b66 100644 --- a/src/main/starlark/builtins_bzl/common/cc/cc_compilation_helper.bzl +++ b/src/main/starlark/builtins_bzl/common/cc/cc_compilation_helper.bzl @@ -346,7 +346,7 @@ def _init_cc_compilation_context( pic_header_module = _header_module_artifact( actions, label, - config.is_sibling_repository_layout(), + sibling_repo_layout, "", ".pic.pcm", ) @@ -354,7 +354,7 @@ def _init_cc_compilation_context( header_module = _header_module_artifact( actions, label, - config.is_sibling_repository_layout(), + sibling_repo_layout, "", ".pcm", ) @@ -364,7 +364,7 @@ def _init_cc_compilation_context( separate_module = _header_module_artifact( actions, label, - config.is_sibling_repository_layout(), + sibling_repo_layout, ".sep", ".pcm", ) @@ -372,7 +372,7 @@ def _init_cc_compilation_context( separate_pic_module = _header_module_artifact( actions, label, - config.is_sibling_repository_layout(), + sibling_repo_layout, ".sep", ".pic.pcm", )