From 7153ce0bdade1df81b462028c798b85a574c6dbb Mon Sep 17 00:00:00 2001 From: Ivo List Date: Mon, 14 Oct 2024 23:52:36 +0200 Subject: [PATCH] [7.4.0] Fix version resolution in AutoloadSymbols (#23974) The logic picked the first instead of the highest version due to a typo. Closes #23936. PiperOrigin-RevId: 684528776 Change-Id: Ic61c84ca2f3489e43fc71944824e7e2311543ab9 Co-authored-by: Fabian Meumertzheim --- .../com/google/devtools/build/lib/packages/AutoloadSymbols.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/google/devtools/build/lib/packages/AutoloadSymbols.java b/src/main/java/com/google/devtools/build/lib/packages/AutoloadSymbols.java index 1de7d085e0e0ef..4df154fb903709 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/AutoloadSymbols.java +++ b/src/main/java/com/google/devtools/build/lib/packages/AutoloadSymbols.java @@ -405,7 +405,7 @@ public ImmutableMap getLoadKeys(SkyFunction.Environmen toImmutableMap( ModuleKey::getName, moduleKey -> moduleKey, - (m1, m2) -> m1.getVersion().compareTo(m2.getVersion()) >= 0 ? m1 : m1)); + (m1, m2) -> m1.getVersion().compareTo(m2.getVersion()) >= 0 ? m1 : m2)); RepositoryMapping repositoryMapping = RepositoryMapping.create( highestVersions.entrySet().stream()