-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sandbox reuse preserves test_tmp
directory
#21253
Comments
@bazel-io flag |
@bazel-io fork 7.1.0 |
Hey Fabian, are you sure about this? I see here that we are only stashing the The testing code I wrote to repro this isn't giving me any hermetic tmp directory being copied into the stash. Under Thanks! |
Thanks for investigating and sorry for the false alarm - I saw the |
Oh I can still fix the _tmp one. I think it makes total sense not to stash that in tests. |
/tmp
directory._tmp
directory
I updated title and description. |
Test actions create a `_tmp` directory that doesn't make sense to stash between different test actions when using `--reuse_sandbox_directories`. This change makes sure that doesn't happen by deleting the directory before stashing. Closes #21412. Fixes #21253. PiperOrigin-RevId: 608566281 Change-Id: I7186f8e5eba7b3110b10963df69ec66cd1402b2c
Description of the bug:
The
_tmp
directory created for tests is preserved in the sandbox stash.While I haven't benchmarked the effect of this, it would at least waste disk space and may also negatively affect performance of sandbox reuse.
Which category does this issue belong to?
No response
What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
No response
Which operating system are you running Bazel on?
No response
What is the output of
bazel info release
?No response
If
bazel info release
returnsdevelopment version
or(@non-git)
, tell us how you built Bazel.No response
What's the output of
git remote get-url origin; git rev-parse HEAD
?No response
Is this a regression? If yes, please try to identify the Bazel commit where the bug was introduced.
No response
Have you found anything relevant by searching the web?
No response
Any other information, logs, or outputs that you want to share?
No response
The text was updated successfully, but these errors were encountered: