Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use auth_patterns with --experimental_downloader_config #21425

Open
calebzulawski opened this issue Feb 20, 2024 · 1 comment
Open

Can't use auth_patterns with --experimental_downloader_config #21425

calebzulawski opened this issue Feb 20, 2024 · 1 comment
Labels
help wanted Someone outside the Bazel team could own this P2 We'll consider working on this in future. (Assignee optional) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug

Comments

@calebzulawski
Copy link

calebzulawski commented Feb 20, 2024

Description of the bug:

I have a downloader config that looks something like:

rewrite https://company.com:8443/(.*) https://company.com/$1

and a rule that looks like:

http_archive(
    name = "archive",
    url = "https://company.com:8443/archive.tar.gz",
    auth_patterns = { "company.com": "Bearer <password>" },
)

Only some networks need the rewrite, otherwise I would just change the URL. With this configuration, the auth_patterns are never used despite pointing to the same host.

Which category does this issue belong to?

No response

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

You would need a remote archive that needs authentication, but I would think changing the url arbitrarily and using the downloader config would reproduce it.

Which operating system are you running Bazel on?

macOS

What is the output of bazel info release?

release 7.0.2

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

Is this a regression? If yes, please try to identify the Bazel commit where the bug was introduced.

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@sgowroji sgowroji added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Feb 20, 2024
@meteorcloudy meteorcloudy added type: feature request help wanted Someone outside the Bazel team could own this P2 We'll consider working on this in future. (Assignee optional) type: bug and removed type: bug untriaged type: feature request labels Feb 27, 2024
@meteorcloudy
Copy link
Member

This definitely looks like something worth fixing. However, due to limited capacity, we don't have time to work on it right now. PRs from the community are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Someone outside the Bazel team could own this P2 We'll consider working on this in future. (Assignee optional) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug
Projects
None yet
Development

No branches or pull requests

5 participants