Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.4.0] Add --incompatible_no_implicit_watch_label #23768

Closed
bazel-io opened this issue Sep 25, 2024 · 2 comments
Closed

[7.4.0] Add --incompatible_no_implicit_watch_label #23768

bazel-io opened this issue Sep 25, 2024 · 2 comments
Milestone
7.4.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #23750
@bazel-io bazel-io added this to the 7.4.0 release blockers milestone Sep 25, 2024
@bazel-io
Copy link
Member Author

bazel-io commented Oct 3, 2024

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkBaseExternalContext.java
src/main/java/com/google/devtools/build/lib/packages/semantics/BuildLanguageOptions.java
src/test/java/com/google/devtools/build/lib/bazel/repository/starlark/BUILD
src/test/shell/bazel/starlark_repository_test.sh

cc: @bazelbuild/triage

@fmeum fmeum mentioned this issue Oct 8, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 8, 2024
@fmeum
[7.4.0] Add --incompatible_no_implicit_watch_label (#23900)
e2193ee 
When the flag is flipped, `ctx.path` no longer watches paths resolved
from `Label` parameters and other methods on `ctx` no longer watch such
paths even with `watch = "no"`.

Closes #23750.

PiperOrigin-RevId: 681978073
Change-Id: I9bef5c735db54c971beb806aa1f1a0eb287e3ff2

(cherry picked from commit 5019697)

Closes #23768
@iancha1992
Copy link
Member

Cherry-picked in #23900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.4.0 release blockers
Development

No branches or pull requests
2 participants
@bazel-io @iancha1992