-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zip: command not found
failing tests
#24056
Comments
zip: command not found
failing tests
Did you upgrade from 7.3.2? The only change to the script since then seems to be 7a18311, which can't really be the cause of the regression. Since zipping up the outputs has always required |
Yeah
Users will occasionally use |
I consider this WAI: as Fabian said, it has always been the case that an external |
See #23479. In recent bazel versions < 7.4, when zip was missing, bazel did not report a failure to user but instead just deleted all of the undeclared outputs. (IIRC in 2023 and earlier, when zip was missing it just didn't zip, but did keep around the undeclared outputs, unzipped.) In any case, it sounds like this will be moot for >= 8. |
Thanks @jwnimmer-tri for identifying the cause! Somewhat embarrassingly, I was the one who fixed that issue, but had no memory of it :) |
Description of the bug:
Tests which use
TEST_UNDECLARED_OUTPUTS_DIR
are failing with the following after upgrading to Bazel 7.4.0Which category does this issue belong to?
No response
What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
Uninstall the
zip
program from your linux worker and run a test which usesTEST_UNDECLARED_OUTPUTS_DIR
.Which operating system are you running Bazel on?
linux
What is the output of
bazel info release
?release 7.4.0
If
bazel info release
returnsdevelopment version
or(@non-git)
, tell us how you built Bazel.No response
What's the output of
git remote get-url origin; git rev-parse HEAD
?No response
If this is a regression, please try to identify the Bazel commit where the bug was introduced with bazelisk --bisect.
Tests pass in
7.3.2
Have you found anything relevant by searching the web?
No response
Any other information, logs, or outputs that you want to share?
No response
The text was updated successfully, but these errors were encountered: