New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend allows a duplicate resource id to be added to the registry with a different type #2

Open

garethsb opened this issue May 18, 2018 · 1 comment

Labels

bug

garethsb commented May 18, 2018

The etcd-based implementation uses type and id as a composite key. See https://github.com/bbc/nmos-registration/blob/master/nmosregistration/etcd_backend.py.

This means that a POST to /resource with a duplicate resource id for a different type is currently accepted.

Please tell me we agree these UUIDs need to be truly unique, not unique per type!

Thanks to @rhastie for discovering this issue.

Contributor

andrewbonney commented May 18, 2018

Yes that does seem like a bug. I doubt we've ever attempted to validate that so far.

andrewbonney added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment