Skip to content
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.

Parent covers children invariant is not respected #391

Closed
m09 opened this issue Apr 2, 2019 · 2 comments
Closed

Parent covers children invariant is not respected #391

m09 opened this issue Apr 2, 2019 · 2 comments

Comments

@m09
Copy link

m09 commented Apr 2, 2019

With the concept of leading comments in the UAST, the simple invariant of parent covering their children is not respected.

I think this might be non-intuitive to many users.

To reproduce:

// This is a comment

var a = 1;

The initial comment is a child of the expression assignment node (on current bblfsh web for example).

@bzz
Copy link
Contributor

bzz commented Apr 11, 2019

Closing as it seems to be a stuck-forever duplicate of #394

@bzz bzz closed this as completed Apr 11, 2019
@m09
Copy link
Author

m09 commented Apr 12, 2019

Indeed it looks like a transferring bug, the original issue was in javascript-driver.

This issue is being transferred. Timeline may not be complete until it finishes.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants