Skip to content
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.

Fix xpath library wrong query failures in case we continue supporting it #426

Open
ncordon opened this issue Aug 19, 2019 · 0 comments
Open

Comments

@ncordon
Copy link
Member

ncordon commented Aug 19, 2019

In #423 we introduced a temporary fix to deal with incorrect queries in XPath (see #424 for context) and fail catching the panic and avoid crashing of clients.

In case we continue supporting XPath we should shift to fixing those issues in the xpath library itself (maybe forking it or doing PRs upstream) and fail with a Go error code instead of a panic.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant