Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpret "at" as an indicator for time #279

Open
giuliofoletto opened this issue Jan 3, 2022 · 0 comments
Open

Interpret "at" as an indicator for time #279

giuliofoletto opened this issue Jan 3, 2022 · 0 comments

Comments

@giuliofoletto
Copy link

It seems that parse("yesterday at 5") does not interpret 5 as time (i.e. hours). It would be nice if this was the case, as this seems a natural way of expressing time of day. From a brief look at the code, it looks like 5 on its own is too general to be interpreted as an indication of hours, however, I think that at could be used to pinpoint the meaning of the integer number.

I understand that in locales that do not use the 24h clock, the simple 5 might be ambiguous (see #210), but at the moment this also does not work in locales that use the 24h clock. For example in the de_DE locale, gestern um 5 and gestern um 17 do not get parsed correctly and the default time of the locale is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant