Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize CI and tox configuration with Briefcase #153

Open
freakboy3742 opened this issue Mar 17, 2024 · 2 comments
Open

Normalize CI and tox configuration with Briefcase #153

freakboy3742 opened this issue Mar 17, 2024 · 2 comments
Labels
enhancement New features, or improvements to existing features. good first issue Is this your first time contributing? This could be a good place to start!

Comments

@freakboy3742
Copy link
Member

What is the problem or limitation you are having?

Travertino has a tox configuration; however, for historical reasons, it uses slightly different targets to the pattern that are currently used by Briefcase (and other BeeWare projects) - most notably those related to coverage reporting.

Describe the solution you'd like

Travertino's tox configuration should provide the same interface used by other BeeWare projects. This includes:

  • a tox -m test3X set of meta-targets
  • Adding coverage generation targets
  • Including a coverage report as part of CI tasks.

Describe alternatives you've considered

Additional context

Briefcase currently enforces a 100% code coverage requirement; It is highly unlikely that Travertino's test suite actually meets this requirement. Being able to easily report current coverage is an important first step to getting to coverage; the "fail if coverage < 100%" rule can be omitted as part of this work.

(Of course, if we're only missing a couple of lines of coverage, adding the extra test cases to get to 100% would also be appreciated)

@freakboy3742 freakboy3742 added enhancement New features, or improvements to existing features. good first issue Is this your first time contributing? This could be a good place to start! labels Mar 17, 2024
@VinayakPaka
Copy link

I would like to work on this issue. Can You please assign this issue to me.

@mhsmith
Copy link
Member

mhsmith commented Aug 15, 2024

We don't have a formal assignment process – it's enough to post a comment as you already have, and then create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features, or improvements to existing features. good first issue Is this your first time contributing? This could be a good place to start!
Projects
None yet
Development

No branches or pull requests

3 participants