-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Livecharts crash WindowsSdkPackageVersion 10.0.22621.38+ #1580
Comments
So Windows App SDK 1.6 finally released but it also requires the new SDK
|
yap same here. I got 'System.NotSupportedException' (inside WinRT.Runtime.dll) and 'System.Reflection.TargetInvocationException' (inside System.Private.CoreLib.dll) exceptions after upgrading WinAppSDK to 1.6. |
Same issue here, can't either use newer Windows App SDK Version or this Charts Control. Please fix the problem and update the package 😊 |
The problem is that LiveCharts uses the Since WinAppSDK 1.6 is relatively new, this is probably something that will be updated soon by someone in the MS team. Sadly, I am afraid that there not much this library can do here :( we need to wait for MS to update the dependencies of this library. |
Did you address this issue with the devs at WindowsAppSdk at github? |
@TRadigk not sure if the issue is on WindowsAppSdk or SkiaSharp, for now I raised the issue to SkiaSharp. |
I guess we need to wait until the Library supports Skiasharp v3 since the new rc version does not work with it yet I’ve been using your Library and appreciate your work. I noticed there was a long gap in updates before the last release candidate and 2.1 and wanted to ask if there could be more frequent updates to the repo or dev branch, at the moment it seems there's only a push when a new release was published. |
My plan is to maintain the library in the long term. About frequently updates, normally I do, but as an open source project completely maintained by my resources (mostly time), sometimes things could get slower than usual. The plan is to also offer a paid version that will mitigate this effect. About SkiaSharp 3, I really hope that this fix also comes to 2.x, because as far as I have read, there will be a lot of breaking changes in the 3.x version, I haven't seen if those changes affect the library, but I am aware that they are working in making the migration not so painful, the library will be updated to SkiaSharp 3 for sure, when? Well it depends on the effort required to do it. |
Just to be clear, this issue is also present in the latest release of SkiaSharp 3 |
I found a reply of the Person who wrote the fix commit about 2.x
|
Today I tried building managed Skiasharp 2.x from source so I can patch it. I invested 3hours but it's a big mess, soo many outdated and eol things cause lots of errors, was able to supress and fix some but it's too much, at the moment I am at 237 Errors x_x. I think I better invest the time in migrating the Library to Skiasharp 3.0 when I get the time, the patched package might not be in nuget yet but you can get it from their azure build server |
+1 |
This is now working on #1622, (requires the package source |
@beto-rodriguez Thanks for this fix.. I tried to, fork, pull down and build to check to make sure the fix also worked in our project. Unfortunately, there are some missing files in the repository (but are listed as part of the Project), As for the missing files that are listed in the LiveChartsCore project file but didn't come down from the fork repository are Geo\world.geojson That didn't prevent it from building however |
GREAT NEWS @beto-rodriguez I can now confirm, out in the wild, you are absolutely correct #1622 commit fixes this bug and returns your charts to operational status in WinUI running against the 1.6 SDK. Well done to you and the SkiaSharp team. Do you happen to have a Patreon or "buy me a coffee" option, I'd like my talk to my Company about giving you some remuneration for your hard work. |
@matthewacme glad to know it is working for you also!
Not for now, but the library will offer a paid version in a future version, thanks for interest in supporting my work! |
You just saved my company 1000s of dollars in purchasing licenses for a commercial charting product (we were looking at Telerik and Syncfusion).
I'd like to suggest it might be worth your while to set up a Patreon account. I think I can make a good case that we should donate 10% of our savings.
Keep up the good work!
Matthew C. Hintzen [he-him-his] | Windows Washer
…________________________________
From: Alberto Rodríguez ***@***.***>
Sent: Friday, October 4, 2024 1:07 PM
To: beto-rodriguez/LiveCharts2 ***@***.***>
Cc: Matthew Hintzen ***@***.***>; Mention ***@***.***>
Subject: Re: [beto-rodriguez/LiveCharts2] Livecharts crash WindowsSdkPackageVersion 10.0.22621.38+ (Issue #1580)
@matthewacme<https://github.com/matthewacme> glad to know it is working for you also!
Do you happen to have a Patreon or "buy me a coffee" option, I'd like my talk to my Company about giving you some remuneration for your hard work.
Not for now, but the library will offer a paid version in a future version, thanks for interest in supporting my work!
—
Reply to this email directly, view it on GitHub<#1580 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACVGS2BHORFDXVU5HYPG2TTZZ3DM5AVCNFSM6AAAAABNSCGIUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJUGE3DSMJWGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Can anyone help me for how to set/configure package source "https://aka.ms/skiasharp-eap/index.json". I'm using in .Net maui. |
I believe you can add it like this in NuGet settings in Visual Studio |
I there, Face the same issue when updating the CommunityToolkit.Mvvm to version 8.3.2 and try to generate the packages from the skiasharp-3 branch but unfortunately without any success. After cloning the repo locally, switch to the skiasharp-3 and adapted the projects configurations to only build the WinUi version of the package. When using the provided scripts, I'm able to generate the packages but when I use them in our application, I received the following exception:
I then tried to generate the package from Visual Studio 17.11.5 but get the following build error in Release:
Switching back the configuration to Debug solved this issue but lead to the first exception when generating the packages. Do you have any advice on how to generate a package that contains the fix? |
@SiL-RHU to make it simpler and avoid building your own NuGet packages, I recommend you remove the reference to LiveCharts packages from NuGet then directly add the reference to LiveChartsCore.SkiaSharpView.Maui it is under the |
Would this work for 'LiveChartsCore.SkiaSharpView.WinUI' as well? Unfortunately, I wasn't able to figure out getting #1622 to work and I guess I broke VS2022 enough that even reverting back to 17.11.4 crashes identically, probably now requiring reinstall, but was curious if this is something I could try afterwords. |
It should work also, you can try before reinstalling vs . Also if you re install the previous visual studio version you will not face this issues on Maui. |
I believe you can add it like this in NuGet settings in Visual Studio On the manage package for solution page, don't forget to select the source to skia sharp (however you name it in the settings) and select "Include Prerelease" |
This is now working using the latest version |
Describe the bug
When loading the Livecharts in XAML in an App with WindowsSdkPackageVersion 10.0.22621.38 or higher it crashes the App and Debugger. WindowsSdkPackageVersion 10.0.22621.34 and lower work as expected
I encountered this when I wanted to update CommunityToolkit.Mvvm from 8.2.2 to 8.3.0, I had to increase WindowsSdkPackageVersion (Microsoft.Windows.CsWinRT 2.1.1 also requires a higher version!)
CommunityToolkit.Mvvm 8.3.0 features many changes like .net8 and other things were made optional.
https://devblogs.microsoft.com/dotnet/announcing-the-dotnet-community-toolkit-830/
To Reproduce
Steps to reproduce the behavior:
Desktop (please complete the following information):
Additional context
LiveChartsCore.SkiaSharpView.WinUI 2.0.0-rc2.1
net8.0-windows10.0.22621.0
Microsoft.WindowsAppSDK 1.5.240802000
The text was updated successfully, but these errors were encountered: