Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Prompt user if committing a file failed #23

Open
ezrizhu opened this issue Jun 20, 2023 · 1 comment
Open

Feat: Prompt user if committing a file failed #23

ezrizhu opened this issue Jun 20, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@ezrizhu
Copy link
Collaborator

ezrizhu commented Jun 20, 2023

If we fail to commit a file, we should prompt the user on whether we should commit the rest or abort here. We could also let the user shell into the overlayfs and then rerun summary.

@mgree
Copy link
Contributor

mgree commented Jun 24, 2023

When might this happen? For something like #18 we should be deleting the original file... but I can imagine a race where the host system and the try process both create a file with the same name. If overlayfs doesn't crash when that happens, we should show that conflict in the summary.

@mgree mgree added the enhancement New feature or request label Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants