Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve urls to file names in RDFs #388

Open
FynnBe opened this issue Apr 29, 2024 · 3 comments
Open

resolve urls to file names in RDFs #388

FynnBe opened this issue Apr 29, 2024 · 3 comments
Assignees

Comments

@FynnBe
Copy link
Member

FynnBe commented Apr 29, 2024

          actually before due to files hosted on zenodo (and not on gh-apges of the old collection repo where we hosted the updated RDFs) we did not have relative paths in the RDFs, so there was a change.

The website needs to resolve relative paths (file names as we don't support folders, aka anything website relevant that does not start with 'http') with the 'parent url' of the rdf url the website is showing content for.

Originally posted by @FynnBe in bioimage-io/collection#49 (comment)

@esgomezm
Copy link
Contributor

esgomezm commented Jun 4, 2024

Related, there are broken links to url for the weights here https://bioimage.io/docs/#/guides/developers-guide?id=model-documentation
Screenshot 2024-06-04 at 15 02 10

@FynnBe
Copy link
Member Author

FynnBe commented Jun 5, 2024

Related, there are broken links to url for the weights

@esgomezm this is a separate issue...

@FynnBe
Copy link
Member Author

FynnBe commented Jun 5, 2024

I checked a resource with a relative path and it is not working yet:

TypeError: e.id.toLowerCase is not a function
    at app.b512ec0e.js:1:1
    at Array.filter (<anonymous>)
    at c (app.b512ec0e.js:1:1)
    at st (app.b512ec0e.js:1:1)
    at app.b512ec0e.js:1:1
    at l (chunk-vendors.e93c4e7e.js:51127:1)
    at Generator._invoke (chunk-vendors.e93c4e7e.js:51127:1)
    at forEach.e.<computed> [as next] (chunk-vendors.e93c4e7e.js:51127:1)
    at n (chunk-vendors.e93c4e7e.js:1:1)
    at s (chunk-vendors.e93c4e7e.js:1:1)

using https://bioimage.io/#/?repo=https%3A%2F%2Fuk1s3.embassy.ebi.ac.uk%2Fpublic-datasets%2Fbioimage.io%2Fcollection.json&type=dataset&id=zero%2Fdataset_stardist_brightfield_zerocostdl4mic

preview works:
image

but the card does not expand and the image disappears after attempting to open the card.
image

The issue is that the relative path is either not resolved at all or resolved using the id field, but as the id might be a legacy id, relative file paths should be resolved using the nickname field instead.
Of course it is possible to move all files around and save them under legacy paths, but as we are slowly moving to our new ids and this is a very small change to the website I'd much prefer the website to be updated in this manner (resolving relative pahts with the nickname, not the id field).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants