Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepting model via UI does not trigger generation of updated collection.json #418

Open
FynnBe opened this issue Aug 30, 2024 · 0 comments
Assignees

Comments

@FynnBe
Copy link
Member

FynnBe commented Aug 30, 2024

https://github.com/bioimage-io/collection/actions/workflows/generate_collection_json.yaml
needs to run to update collection_draft.json and collection.json accordingly.

alternatively the accept action doesn't just move the folder on s3 but actually triggers the publish workflow that takes care of the full process and updates the logs accordingly as well.
This would make it a bit easier to keep track of what happened (also because then there is a CI log entry)

I know the initial motivation to skip the publish workflow (that essentially just does the moving) was to speed up publication on bioimage.io, but if the collection.json isn't updated this doesn't work at all instead.

(We've been disussing this issue elsewhere already, just couldn't find it rn)

To clarify the current issue:
with the draft overview generated from collection_draft.json the accepted model is still listed there and looking at it's details will trigger a 404 as the files have been moved.
The collection.json that holds the content for bioimage.io does not know about this move, so the model is still not listed there after this kind of publishing..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants