Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/apisix] Use Apisix-Base build for the default Apisix image #42525

Open
mrmm opened this issue Jul 27, 2023 · 6 comments
Open

[bitnami/apisix] Use Apisix-Base build for the default Apisix image #42525

mrmm opened this issue Jul 27, 2023 · 6 comments
Labels
apisix feature-request on-hold Issues or Pull Requests with this label will never be considered stale

Comments

@mrmm
Copy link

mrmm commented Jul 27, 2023

Name and Version

bitnami/apisix:4.3.1

What is the problem this feature will solve?

Allow the usage of plugins that are included with the Apisix-Base version.

What is the feature you are proposing to solve the problem?

When using a plugin that is not included by default gzip for instance the DataPlane displays the error need to build APISIX-Base to support setting gzip while reading response header from upstream.

What alternatives have you considered?

No response

@github-actions github-actions bot added the triage Triage is needed label Jul 27, 2023
@mrmm
Copy link
Author

mrmm commented Jul 27, 2023

@javirln Is this possible with the current state of Apisix base modules?

@mrmm mrmm changed the title Use Apisix-Base as the default image [bitnami/apisix] Use Apisix-Base as the default image Jul 27, 2023
@mrmm mrmm changed the title [bitnami/apisix] Use Apisix-Base as the default image [bitnami/apisix] Use Apisix-Base for the default Apisix image Jul 27, 2023
@mrmm mrmm changed the title [bitnami/apisix] Use Apisix-Base for the default Apisix image [bitnami/apisix] Use Apisix-Base build for the default Apisix image Jul 27, 2023
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Jul 31, 2023
@bitnami-bot bitnami-bot assigned andresbono and unassigned javsalgar Jul 31, 2023
@mrmm
Copy link
Author

mrmm commented Aug 3, 2023

@andresbono Is there a way to help in this I am not familiar on how the stack smith prepares the packages for the docker images.
Let me know if I can make this task easier 🙏

@andresbono
Copy link
Contributor

andresbono commented Aug 4, 2023

Hi, thank you for filling this issue! We have created an internal ticket to evaluate your feature request, it seems an interesting addition. If everything looks good, and we can release the container image with APISIX + APISIX-Base we will ask you for feedback.

In the meantime, can you think of any drawbacks of building APISIX with APISIX-Base instead of the regular OpenResty? Is there any current feature that would be lost if we switch to APISIX-Base?

Thank you for your collaboration!!

@andresbono andresbono added on-hold Issues or Pull Requests with this label will never be considered stale and removed in-progress labels Aug 4, 2023
@mrmm
Copy link
Author

mrmm commented Aug 6, 2023

Hello @andresbono Thanks a lot for dedicating the time to this request 🙏

As far as I can find (in the docs, GitHub repo of APISIX, and its related repos) there would not be any missing feature from the APISIX-Base build compared to the regular OpenResty build.

On the contrary, there are quite a number of Plugins that can be used when using APISIX-Base below is what should (AFAIK) some useful plugins that require this build:

  • real-ip: customize how/from where to get the client real IP
  • gzip: enable/disable gzip of the proxied traffic at APISIX level
  • proxy-cache: allows you enable/disable proxy buffering
  • client-control: allows you to override the max_body_size dynamically
  • prometheus: useful if you work with Prometheus to expose some metrics

An alternative solution would be to build two images apisix and apisix-base (not sure of the overhead, besides needing to maintain 1 more docker image of APISIX) this will give the liberty to the user to choose what version of APISIX to deploy. For the Helm chart, the regular APISIX build can be kept as the default docker image.

Let me know how can I help/off-load some of the work on my side if needed 🙏

@github-actions github-actions bot added triage Triage is needed and removed on-hold Issues or Pull Requests with this label will never be considered stale labels Aug 6, 2023
@github-actions github-actions bot added on-hold Issues or Pull Requests with this label will never be considered stale and removed triage Triage is needed labels Aug 8, 2023
@okassov
Copy link

okassov commented Dec 3, 2023

Any updates?

@sereneshikari
Copy link

I'm interested in this too! A lot of useful features are missing in the standard build as already mentioned so providing APISIX built on top of APISIX-Base would be beneficial or at least, steps on how to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apisix feature-request on-hold Issues or Pull Requests with this label will never be considered stale
Projects
None yet
Development

No branches or pull requests

5 participants