Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

Relying on noAssert #215

Open
BridgeAR opened this issue Mar 10, 2018 · 1 comment
Open

Relying on noAssert #215

BridgeAR opened this issue Mar 10, 2018 · 1 comment

Comments

@BridgeAR
Copy link

I just checked multiple libraries that used the noAssert argument in the Node.js Buffer module.

It seems like the code here duplicates a old Node.js modules version and contains that argument. I highly recommend to remove that one as it allows undefined behavior and there are more issues about coercing the input.

I am not sure if the native module is used at all. If that is the case, please remove the noAssert argument there since the upcoming Node.js version 10.x dropped support for it.

Refs: nodejs/node#18395

@BridgeAR
Copy link
Author

BridgeAR commented Apr 1, 2018

Ping.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant