Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking changes and package.json #24

Open
Qard opened this issue Jul 7, 2012 · 3 comments
Open

breaking changes and package.json #24

Qard opened this issue Jul 7, 2012 · 3 comments

Comments

@Qard
Copy link

Qard commented Jul 7, 2012

When suggesting a change that breaks compatibility with previous versions, the bot should either update the engine in package.json to >= 0.8.0 or, ideally; be clever enough to put in detection code. For example;

path.exists(*)

becomes

(parseInt(process.version.split('.')[1]) > 8 ? fs.exists(*) : path.exists(*))
@pksunkara
Copy link

Why not fs.exists(*) || path.exists(*) ?

Or even better (fs.exists || path.exists)(*)

@Qard
Copy link
Author

Qard commented Jul 7, 2012

Well, the first would fail when trying to execute a function that doesn't exist, but the second should work.

@blakmatrix
Copy link
Owner

#21 #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants