Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UISeeds - Tag Component #26

Closed
slowbot opened this issue Apr 12, 2023 · 17 comments
Closed

UISeeds - Tag Component #26

slowbot opened this issue Apr 12, 2023 · 17 comments
Assignees

Comments

@slowbot
Copy link
Collaborator

slowbot commented Apr 12, 2023

Description

Transfer the Tag component from UIC to Seeds

Links

Eng Audit
Zero height Docs

Additional Details

  • We are removing uppercase styles
  • We are scoping down variants and making the pill size the default
  • We are reducing down to two sizes, md and lg
  • We are making lighter bg colors defaults and shifting darker colors to inverse variants
  • Adding an icon left and right option

Acceptance Criteria

Figma Design Spec

QA review/instructions

@jaredcwhite
Copy link
Collaborator

For the "in process" tag variant, should it be referencing the yellow color values directly, or use the warn/warn-light colors?

@jaredcwhite
Copy link
Collaborator

Is there no "squarer" option then? It's only the pill shape?

@emilyjablonski
Copy link
Contributor

+1 to "squarer" option, and also that I'm not seeing the version of this with larger padding like we have in the listing form and want to ensure that is intentional?

Also noting that it looks like this component might have a dependency on Tooltip from the best practices docs

  • "The ARIA label for a tag should align with the visible label text on the tag." - I don't think we need an aria label in this case - what would it include that isn't in the text content?

@slowbot
Copy link
Collaborator Author

slowbot commented Apr 18, 2023

  • we have intentionally removed the squared option and additional padding, hoping this could be handled with theming. We felt the other style too closely resembled the Button component

@jaredcwhite
Copy link
Collaborator

Maybe we should review recommendations here and also on Message so it's clear when to use one vs. the other. Either one could potentially be used to indicate the "status" of something…

@slowbot
Copy link
Collaborator Author

slowbot commented Apr 18, 2023

@emilyjablonski

There is a use case where we want the tag to represent "status", and in those instances, we found that it's recommended that they support aria-live

"When tags are used to call out new content that is dynamically loaded onto a page, be sure to use ARIA live regions to alert screen readers of the change." https://designsystem.digital.gov/components/tag/

Can push this to a v2 and handle the uptake of specific use cases if that's better.

@jaredcwhite
Copy link
Collaborator

@slowbot Wouldn't an alert or toast be better suited for live updates? I can't really conceive of a tag conveying anything time-sensitive or in response to an action

@emilyjablonski
Copy link
Contributor

^ +1, we also don't currently have any use cases of dynamic tags that load onto a page

@slowbot
Copy link
Collaborator Author

slowbot commented May 2, 2023

I trust you both. It seems that we have tag components in Partners that signify draft and published states for a listing. Was thinking they could use some form of labeling. Can always push on this until it comes up again.

@slowbot
Copy link
Collaborator Author

slowbot commented May 2, 2023

@jaredcwhite

"For the "in process" tag variant, should it be referencing the yellow color values directly, or use the warn/warn-light colors?"

This is a good question. I think we thought linking to yellow directly would be better for this use case but could be convinced otherwise.

@jaredcwhite
Copy link
Collaborator

jaredcwhite commented Jul 11, 2023

@slowbot For the "Highlight Warm/Cool" options, is there the possibility of calling them "Accent Warm/Cool"? I'm just curious why the naming discrepancy on the tag variants vs. color tokens.

@jaredcwhite jaredcwhite mentioned this issue Jul 13, 2023
9 tasks
@jaredcwhite
Copy link
Collaborator

Will go update zeroheight for this one as well as Button.

@slowbot
Copy link
Collaborator Author

slowbot commented Jul 28, 2023

@jaredcwhite We can talk about it. I think there was a mixed proposal of removing the "accent" name everywhere and moving to "highlight" for token and variants

@jaredcwhite
Copy link
Collaborator

jaredcwhite commented Jul 28, 2023

@slowbot Cool. Also I'm noticing now the Tooltip example in zeroheight…we don't have any tooltip component currently, so wondering if we should remove that for now.

@slowbot
Copy link
Collaborator Author

slowbot commented Aug 4, 2023

Yeah it was a use case in Detroit but we can remove for now. @jaredcwhite

@slowbot
Copy link
Collaborator Author

slowbot commented Aug 4, 2023

@jaredcwhite Should we create a new ticket for updating token names from accent to highlight?

@slowbot
Copy link
Collaborator Author

slowbot commented Aug 14, 2023

Closing and creating a new ticket for highlight naming story #60

@slowbot slowbot closed this as completed Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants