-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UISeeds - Tag Component #26
Comments
For the "in process" tag variant, should it be referencing the yellow color values directly, or use the warn/warn-light colors? |
Is there no "squarer" option then? It's only the pill shape? |
+1 to "squarer" option, and also that I'm not seeing the version of this with larger padding like we have in the listing form and want to ensure that is intentional? Also noting that it looks like this component might have a dependency on Tooltip from the best practices docs
|
|
Maybe we should review recommendations here and also on Message so it's clear when to use one vs. the other. Either one could potentially be used to indicate the "status" of something… |
There is a use case where we want the tag to represent "status", and in those instances, we found that it's recommended that they support aria-live "When tags are used to call out new content that is dynamically loaded onto a page, be sure to use ARIA live regions to alert screen readers of the change." https://designsystem.digital.gov/components/tag/ Can push this to a v2 and handle the uptake of specific use cases if that's better. |
@slowbot Wouldn't an alert or toast be better suited for live updates? I can't really conceive of a tag conveying anything time-sensitive or in response to an action |
^ +1, we also don't currently have any use cases of dynamic tags that load onto a page |
I trust you both. It seems that we have tag components in Partners that signify draft and published states for a listing. Was thinking they could use some form of labeling. Can always push on this until it comes up again. |
"For the "in process" tag variant, should it be referencing the yellow color values directly, or use the warn/warn-light colors?" This is a good question. I think we thought linking to yellow directly would be better for this use case but could be convinced otherwise. |
@slowbot For the "Highlight Warm/Cool" options, is there the possibility of calling them "Accent Warm/Cool"? I'm just curious why the naming discrepancy on the tag variants vs. color tokens. |
Will go update zeroheight for this one as well as Button. |
@jaredcwhite We can talk about it. I think there was a mixed proposal of removing the "accent" name everywhere and moving to "highlight" for token and variants |
@slowbot Cool. Also I'm noticing now the Tooltip example in zeroheight…we don't have any tooltip component currently, so wondering if we should remove that for now. |
Yeah it was a use case in Detroit but we can remove for now. @jaredcwhite |
@jaredcwhite Should we create a new ticket for updating token names from accent to highlight? |
Closing and creating a new ticket for highlight naming story #60 |
Description
Transfer the Tag component from UIC to Seeds
Links
Eng Audit
Zero height Docs
Additional Details
Acceptance Criteria
Figma Design Spec
QA review/instructions
The text was updated successfully, but these errors were encountered: