Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a vertical prop to the Tabs component to keep it always vertical #79

Open
jaredcwhite opened this issue Mar 14, 2024 · 4 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@jaredcwhite
Copy link
Collaborator

Currently the Seeds Tabs component switches from horizontal tabs to vertical tabs based on a mobile breakpoint. That's fine to have for some use cases, but for other use cases we need tabs which are always stacked vertically (perhaps living in a sidebar).

Thus we should add a vertical or verticalOnly or keepVertical (some naming ideas, feel free to comment) boolean prop to Tabs which would override the media query-based CSS and keep the tabs vertical no matter what the screen size. That way the author of the template which consumes the Tabs component can choose if they want this functionality in that particular case.

@jaredcwhite jaredcwhite added the enhancement New feature or request label Mar 14, 2024
@jaredcwhite
Copy link
Collaborator Author

This would likely solve the need that prompted #73.

@sarahlazarich
Copy link
Collaborator

we can use tabs for the account sidebar since it's a simpler implementation than menu

@jaredcwhite
Copy link
Collaborator Author

Just adding a note here we'd also need to incorporate a layout where the tab panel is the right of the tabs, not below (so the tabs actually are in a sidebar). Right now tabs are always directly above the active tab panel no matter what.

@sarahlazarich
Copy link
Collaborator

no product QA needed until account screens are built out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants