Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly define structure of a valid user and database name #26

Open
theMarix opened this issue Jan 30, 2018 · 1 comment
Open

Explicitly define structure of a valid user and database name #26

theMarix opened this issue Jan 30, 2018 · 1 comment

Comments

@theMarix
Copy link

With the current implementation validity of user and database names is left to the backend implementation. This can cause confusing issues if switched between instances using different backends and it is also easily visible to a user to see what values are valid from first principles. I suggest to explicitly define a set of valid characters, e.g. alphanumeric, dash and underscore and enforce this in the API layer instead of the backends.

@sebastianneubauer
Copy link
Member

We can safely add "postgres" to the list of forbidden database and usernames...I heard this leads to a terrible failure of the postgraas and that is even not a surprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants