Replies: 1 comment
-
Hi @erjans! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi!
Thanks for the great library! This is my first GitHub discussion, so please correct me if I'm not following any standards.
In my current project, I have found one possible flaw or drawback which could be interesting to address. It revolves around the default choice for parameters in the
cwt_coefficients
inComprehensiveFCParameters
.Here,
w
is considered the width of the wavelet (related to frequency) andcoeff
is related to time.The value for the
cwt_coefficients
is extracted by the functioncwt_coefficients
in thetsfresh.feature_extraction.feature_calculators
module. From my understanding, this function calculates the CWT usingscipy.signal.cwt
for all time points in the signalx
. Afterwards, it simply saves the coefficient of interest into the res list by indexing the result from the CWT calculation.To my understanding, using
coeff in range(15)
will result in taking only the first 15 coefficients. In my case, my time series are ~1600 time points, meaning that I miss the majority of the extracted CWT components.I believe a better solution would be to let
coeff
be evenly spaced across the length of the input instead, so as not to miss the majority of possible important CWT features.Please let me know if I've understood something incorrectly.
Beta Was this translation helpful? Give feedback.
All reactions