Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position title in line with the bottom of the logo #1

Open
bobbingwide opened this issue Oct 2, 2019 · 2 comments
Open

Position title in line with the bottom of the logo #1

bobbingwide opened this issue Oct 2, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Oct 2, 2019

On the desktop display, with the vertical menu, the title of each page should be in line with the bottom of the logo.

Proposed solution

Taking a pragmatic approach

  • Simplify the title code template
  • Style the title so that it appears in the correct position.
  • Add filter logic to maison_edge_filter_title_area_height_params to force values for the title, overriding any settings for each individual page.
  • Then, for each page where a new title had been created as part of the content, remove that title ( h3 ) from the content.
@bobbingwide bobbingwide added the bug Something isn't working label Oct 2, 2019
@bobbingwide bobbingwide self-assigned this Oct 2, 2019
@bobbingwide
Copy link
Owner Author

Note: The Title has to be enabled. i.e. The Edge Title Show Title Area selection should be Default or Yes, not No.

@bobbingwide
Copy link
Owner Author

bobbingwide commented Oct 2, 2019

Note: When viewing an individual project in Mobile layout the title sometimes shows a background image, and or a subtitle. And the h1 can wrap. It looks like the template needs to be further simplified.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant