Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure modal popup is fully visible on the desktop #2

Open
bobbingwide opened this issue Oct 2, 2019 · 1 comment
Open

Ensure modal popup is fully visible on the desktop #2

bobbingwide opened this issue Oct 2, 2019 · 1 comment
Assignees
@bobbingwide
Labels
bug Something isn't working

Comments

@bobbingwide
Copy link
Owner

On my laptop the moda popup displayed for team members is partially obscured by the vertical header.

Proposed solution

Reduce the maximum width and adjust the left margin to take into account the vertical header.
@bobbingwide bobbingwide added the bug Something isn't working label Oct 2, 2019
@bobbingwide bobbingwide self-assigned this Oct 2, 2019
@bobbingwide bobbingwide changed the title Ensure modal popup is visible on the desktop Ensure modal popup is fully visible on the desktop Oct 2, 2019
@bobbingwide
Copy link
Owner Author

bobbingwide commented Oct 2, 2019 •
edited
Loading

There should be no left margin applied for Mobile devices.
And the floating mobile header should be hidden when the modal popup is displayed.
Otherwise we can't see the previous and next or close controls.
We can see them in this screen capture.
image

The WordPress admin bar can also get in the way, hiding the close button, which is outside of the awsm-modal-items-main block so may need styling separately.

bobbingwide added a commit that referenced this issue Oct 8, 2019
@bobbingwide
Issue #2 - don't apply left margin when vertical menu not being used
663358d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobbingwide bobbingwide

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bobbingwide