database corrupt error when mutex table not empty

[mrkazoodle]

I recently got the error message by e-mail:
Subject: [Django][Bots severe error] Database is damaged
Body:
"!Bots database is locked!
Bots did an integrity check on the database, but database was not OK.
Manual action is needed!
Bots has stopped processing EDI files."

After opening the database successfully with dbeaver (so not actually damaged or corrupt), I compared the tables with the test environment's version. I found that the mutex table was not empty, and in the docs, I found that this is a table used for 'locking' the database so that only one instance can use it. After deleting it's entry and restarting the bots service, everything worked fine.

My question: please make the error a bit easier to understand:

• the database was NOT damaged, in a sense that it would be corrupt and beyond repair,
• ok, it said the database is locked, but please make this the subject of the e-mail, and
• explain that the mutex table should be empty when there is no bots instance running

This, I experienced with version 3.2 of Bots on Ubuntu 16.04 LTS, after running for 7 months without any issues.

[djfurman]

Thanks @mrkazoodle - I appreciate the detailed description of what the cause was.

The mutex table it designed ot achieve a mutex/semaphore pattern for the DB, but you're certainly correct that the error should point to that. I think it's an overly general catch. I'll see i fwe can get it down a little more specifically in the next release.