Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setCurrentUser() #264

Open
nielspeen opened this issue Aug 3, 2021 · 0 comments
Open

Add a setCurrentUser() #264

nielspeen opened this issue Aug 3, 2021 · 0 comments

Comments

@nielspeen
Copy link

nielspeen commented Aug 3, 2021

The outcome of a lot of functions depends on vfsStream::getCurrentUser() but there is currently no vfsStream::setCurrentUser(). Instead, it is assumed the current Linux user is relevant or that testing everything as a single-user is sufficient.

In my experience this is not necessarily true. Scripts may be run as root and individual queue workers may run under varying users. (E.g. when files are shared with other non-web applications that run as different users for security purposes.)

Alternatively you may consider an option to disable owner/permission checking altogether, as those can still be tested for separately. (Note that some checks are missing/wrong already: normally only root can use chown, but in vfsStream any user can chown if they're the current owner.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant