Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QC: test mapping files for expected databases #218

Open
DeniseSl22 opened this issue Mar 8, 2023 · 3 comments
Open

QC: test mapping files for expected databases #218

DeniseSl22 opened this issue Mar 8, 2023 · 3 comments
Assignees

Comments

@DeniseSl22
Copy link
Contributor

  • Based on the expected databases in a mapping file (which are different for GeneProtein/Metabolite/Etc.), there should be an output which databases should be present in the mapping files. @egonw @tabbassidaloii @DeniseSl22
@egonw
Copy link
Member

egonw commented Mar 17, 2023

expected databases in a mapping file

What do you mean with "expected" here? Expected by whom? Right now, the QC tool expects the same databases in the next release as the previous release. That is in the output.

You mean the BridgeDb Derby schema version, right?

@DeniseSl22
Copy link
Contributor Author

Well, apparently that is not a "foolproof" technique (as the issues with the GeneProtein Mapping files have shown). We know which databases we want to have represented in the mapping files, right? So, I think there should be a warning if one of those isn't there.... vs checking the content per database which is being done now.

@egonw
Copy link
Member

egonw commented Mar 20, 2023

When you compare with a previous database it already does report which databases are added or removed. That is separate from the differences.

What it does not do, is look at the attributes in both files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants