Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black Bands Problem #20

Open
esgarlock opened this issue Feb 18, 2021 · 2 comments
Open

Black Bands Problem #20

esgarlock opened this issue Feb 18, 2021 · 2 comments

Comments

@esgarlock
Copy link
Collaborator

Going through GlobeCorr with Justin Cook, came across this (he was using a MacBook Pro, 2016 OS Catalina with Chrome Browser).

  • Uploaded sample_small.csv
  • Clicked on positive correlation colour
  • Clicked on the colour slider and chose a new colour
  • Clicked on palette, one band goes black on the globe. We now have some bands that are the positive colour, all the negative bands are a colour, but there is one black band. When you hover over this band the label that should come up is also all blacked out so you can’t read it. (see below)

black_band_1

We were able to replicate the problem going through the same steps

black_band_2

  • We were also able to “build on” this problem and create more black bands by clicking on the palette some more.

black_band_multiple

@innovate-invent
Copy link
Collaborator

I wonder if this is related to brinkmanlab/IslandCompare#177

@innovate-invent
Copy link
Collaborator

innovate-invent commented Feb 24, 2021

Looks like there is a math issue when picking colors. @mariamarab I am not sure how you decided on this equation:
https://github.com/brinkmanlab/exposomeglobe/blob/dd15f72d1f34ab8bf965c79c79354eaae9368ce9/src/components/ExposomeGlobe.vue#L38-L41

If intensity is >0.75 and a color component is a low value, say r=1, the color will be negative. The only valid color values are between 0 and 255.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants