From 24835e9e5dc50c3086ae7e7f220d1bee3d237f85 Mon Sep 17 00:00:00 2001 From: Riley Grant Date: Fri, 14 Jul 2023 11:20:34 -0400 Subject: [PATCH] Update feedback page and rename to contact page --- browser/cypress/e2e/nav_bar_pages.cy.ts | 4 ++-- ...backPage.spec.tsx => ContactPage.spec.tsx} | 6 +++--- .../src/{FeedbackPage.tsx => ContactPage.tsx} | 20 +++++++++++++++---- browser/src/NavBar.tsx | 4 ++-- browser/src/Routes.tsx | 10 +++++----- ...pec.tsx.snap => ContactPage.spec.tsx.snap} | 16 ++++++++++----- browser/src/robots.txt | 2 +- 7 files changed, 40 insertions(+), 22 deletions(-) rename browser/src/{FeebackPage.spec.tsx => ContactPage.spec.tsx} (60%) rename browser/src/{FeedbackPage.tsx => ContactPage.tsx} (70%) rename browser/src/__snapshots__/{FeebackPage.spec.tsx.snap => ContactPage.spec.tsx.snap} (85%) diff --git a/browser/cypress/e2e/nav_bar_pages.cy.ts b/browser/cypress/e2e/nav_bar_pages.cy.ts index 2e2e906cd..156e75d90 100644 --- a/browser/cypress/e2e/nav_bar_pages.cy.ts +++ b/browser/cypress/e2e/nav_bar_pages.cy.ts @@ -54,8 +54,8 @@ describe('Home Page', () => { pageHeader: 'publications from the gnomAD group', }, { - pageTitle: 'Feedback', - pageUrl: '/feedback', + pageTitle: 'Contact', + pageUrl: '/contact', pageHeader: 'Tell us how you use gnomAD', }, { diff --git a/browser/src/FeebackPage.spec.tsx b/browser/src/ContactPage.spec.tsx similarity index 60% rename from browser/src/FeebackPage.spec.tsx rename to browser/src/ContactPage.spec.tsx index 1bf8390eb..a6c9dc5ca 100644 --- a/browser/src/FeebackPage.spec.tsx +++ b/browser/src/ContactPage.spec.tsx @@ -4,11 +4,11 @@ import 'jest-styled-components' import React from 'react' import renderer from 'react-test-renderer' -import FeedbackPage from './FeedbackPage' +import ContactPage from './ContactPage' import { withDummyRouter } from '../../tests/__helpers__/router' -test('Feedback Page has no unexpected changes', () => { - const tree = renderer.create(withDummyRouter()) +test('Contact Page has no unexpected changes', () => { + const tree = renderer.create(withDummyRouter()) expect(tree).toMatchSnapshot() }) diff --git a/browser/src/FeedbackPage.tsx b/browser/src/ContactPage.tsx similarity index 70% rename from browser/src/FeedbackPage.tsx rename to browser/src/ContactPage.tsx index db3ca25af..a47fc0885 100644 --- a/browser/src/FeedbackPage.tsx +++ b/browser/src/ContactPage.tsx @@ -7,8 +7,8 @@ import InfoPage from './InfoPage' export default () => ( - - Feedback + + Contact

Tell us how you use gnomAD and your wish list by filling out{' '} @@ -27,9 +27,21 @@ export default () => ( {/* @ts-expect-error TS(2786) FIXME: 'ExternalLink' cannot be used as a JSX component. */} GitHub - {' '} + + . +

+ +

+ For questions about gnomAD, check out the{' '} {/* @ts-expect-error TS(2786) FIXME: 'ExternalLink' cannot be used as a JSX component. */} - or by email. + help page. +

+ +

+ Note that, for many reasons (including consent and data usage restrictions), we do not have + (and cannot share) phenotype information. Overall, we have limited information that we can + share for some cohorts, such as last known age in bins of 5 years (when known) and chromosomal + sex.

diff --git a/browser/src/NavBar.tsx b/browser/src/NavBar.tsx index 2ecd85c77..c3cc1c49d 100644 --- a/browser/src/NavBar.tsx +++ b/browser/src/NavBar.tsx @@ -132,8 +132,8 @@ const NavBar = () => {

  • - - Feedback + + Contact
  • diff --git a/browser/src/Routes.tsx b/browser/src/Routes.tsx index 94aac50f4..f61b3b51b 100644 --- a/browser/src/Routes.tsx +++ b/browser/src/Routes.tsx @@ -10,7 +10,7 @@ import DocumentTitle from './DocumentTitle' // Content pages const AboutPage = lazy(() => import('./AboutPage')) const TeamPage = lazy(() => import('./TeamPage/TeamPage')) -const FeedbackPage = lazy(() => import('./FeedbackPage')) +const ContactPage = lazy(() => import('./ContactPage')) const DownloadsPage = lazy(() => import('./DownloadsPage/DownloadsPage')) const HelpPage = lazy(() => import('./help/HelpPage')) const HelpTopicPage = lazy(() => import('./help/HelpTopicPage')) @@ -26,8 +26,8 @@ const VariantPageRouter = lazy(() => import('./VariantPageRouter')) const ShortTandemRepeatPage = lazy(() => import('./ShortTandemRepeatPage/ShortTandemRepeatPage')) const ShortTandemRepeatsPage = lazy(() => import('./ShortTandemRepeatsPage/ShortTandemRepeatsPage')) -const VariantCooccurrencePage = lazy(() => - import('./VariantCooccurrencePage/VariantCooccurrencePage') +const VariantCooccurrencePage = lazy( + () => import('./VariantCooccurrencePage/VariantCooccurrencePage') ) // Other pages @@ -161,9 +161,9 @@ const Routes = () => { - + - } /> + } /> diff --git a/browser/src/__snapshots__/FeebackPage.spec.tsx.snap b/browser/src/__snapshots__/ContactPage.spec.tsx.snap similarity index 85% rename from browser/src/__snapshots__/FeebackPage.spec.tsx.snap rename to browser/src/__snapshots__/ContactPage.spec.tsx.snap index 4b8a7cb60..a99d1f79e 100644 --- a/browser/src/__snapshots__/FeebackPage.spec.tsx.snap +++ b/browser/src/__snapshots__/ContactPage.spec.tsx.snap @@ -1,6 +1,6 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP -exports[`Feedback Page has no unexpected changes 1`] = ` +exports[`Contact Page has no unexpected changes 1`] = ` .c3 { color: #1173bb; -webkit-text-decoration: none; @@ -96,7 +96,7 @@ exports[`Feedback Page has no unexpected changes 1`] = `

    - Feedback + Contact

    @@ -136,18 +136,24 @@ exports[`Feedback Page has no unexpected changes 1`] = ` > GitHub + . +

    +

    + For questions about gnomAD, check out the - or by - email + help page .

    +

    + Note that, for many reasons (including consent and data usage restrictions), we do not have (and cannot share) phenotype information. Overall, we have limited information that we can share for some cohorts, such as last known age in bins of 5 years (when known) and chromosomal sex. +

    Follow us on Twitter diff --git a/browser/src/robots.txt b/browser/src/robots.txt index f1fd230b3..d713cd27a 100644 --- a/browser/src/robots.txt +++ b/browser/src/robots.txt @@ -8,5 +8,5 @@ Allow: /news/changelog/ Allow: /downloads/ Allow: /policies/ Allow: /publications/ -Allow: /feedback/ +Allow: /contact/ Allow: /help/