From d41bdb4c36df47cf6675dc8b2a3ecfc279227014 Mon Sep 17 00:00:00 2001
From: Riley Grant <grantrileyh@gmail.com>
Date: Fri, 17 May 2024 13:13:13 -0500
Subject: [PATCH] wip(browser): correct populations per dataset

---
 .../__snapshots__/VariantPage.spec.tsx.snap   | 46 +++++++++----------
 dataset-metadata/gnomadPopulations.ts         |  6 +--
 2 files changed, 26 insertions(+), 26 deletions(-)

diff --git a/browser/src/VariantPage/__snapshots__/VariantPage.spec.tsx.snap b/browser/src/VariantPage/__snapshots__/VariantPage.spec.tsx.snap
index 4743e7d84..f108a8da3 100644
--- a/browser/src/VariantPage/__snapshots__/VariantPage.spec.tsx.snap
+++ b/browser/src/VariantPage/__snapshots__/VariantPage.spec.tsx.snap
@@ -951,7 +951,7 @@ exports[`VariantPage with the dataset "gnomad_r3" has no unexpected changes 1`]
                         onClick={[Function]}
                         type="button"
                       >
-                        Admixed American
+                        European (Finnish)
                       </button>
                     </th>
                     <td
@@ -992,7 +992,7 @@ exports[`VariantPage with the dataset "gnomad_r3" has no unexpected changes 1`]
                         onClick={[Function]}
                         type="button"
                       >
-                        European
+                        Admixed American
                       </button>
                     </th>
                     <td
@@ -1279,7 +1279,7 @@ exports[`VariantPage with the dataset "gnomad_r3" has no unexpected changes 1`]
                         onClick={[Function]}
                         type="button"
                       >
-                        Remaining
+                        Remaining individuals
                       </button>
                     </th>
                     <td
@@ -10820,7 +10820,7 @@ exports[`VariantPage with the dataset "gnomad_r3_controls_and_biobanks" has no u
                         onClick={[Function]}
                         type="button"
                       >
-                        Admixed American
+                        European (Finnish)
                       </button>
                     </th>
                     <td
@@ -10861,7 +10861,7 @@ exports[`VariantPage with the dataset "gnomad_r3_controls_and_biobanks" has no u
                         onClick={[Function]}
                         type="button"
                       >
-                        European
+                        Admixed American
                       </button>
                     </th>
                     <td
@@ -11148,7 +11148,7 @@ exports[`VariantPage with the dataset "gnomad_r3_controls_and_biobanks" has no u
                         onClick={[Function]}
                         type="button"
                       >
-                        Remaining
+                        Remaining individuals
                       </button>
                     </th>
                     <td
@@ -20692,7 +20692,7 @@ exports[`VariantPage with the dataset "gnomad_r3_non_cancer" has no unexpected c
                         onClick={[Function]}
                         type="button"
                       >
-                        Admixed American
+                        European (Finnish)
                       </button>
                     </th>
                     <td
@@ -20733,7 +20733,7 @@ exports[`VariantPage with the dataset "gnomad_r3_non_cancer" has no unexpected c
                         onClick={[Function]}
                         type="button"
                       >
-                        European
+                        Admixed American
                       </button>
                     </th>
                     <td
@@ -21020,7 +21020,7 @@ exports[`VariantPage with the dataset "gnomad_r3_non_cancer" has no unexpected c
                         onClick={[Function]}
                         type="button"
                       >
-                        Remaining
+                        Remaining individuals
                       </button>
                     </th>
                     <td
@@ -30564,7 +30564,7 @@ exports[`VariantPage with the dataset "gnomad_r3_non_neuro" has no unexpected ch
                         onClick={[Function]}
                         type="button"
                       >
-                        Admixed American
+                        European (Finnish)
                       </button>
                     </th>
                     <td
@@ -30605,7 +30605,7 @@ exports[`VariantPage with the dataset "gnomad_r3_non_neuro" has no unexpected ch
                         onClick={[Function]}
                         type="button"
                       >
-                        European
+                        Admixed American
                       </button>
                     </th>
                     <td
@@ -30892,7 +30892,7 @@ exports[`VariantPage with the dataset "gnomad_r3_non_neuro" has no unexpected ch
                         onClick={[Function]}
                         type="button"
                       >
-                        Remaining
+                        Remaining individuals
                       </button>
                     </th>
                     <td
@@ -40436,7 +40436,7 @@ exports[`VariantPage with the dataset "gnomad_r3_non_topmed" has no unexpected c
                         onClick={[Function]}
                         type="button"
                       >
-                        Admixed American
+                        European (Finnish)
                       </button>
                     </th>
                     <td
@@ -40477,7 +40477,7 @@ exports[`VariantPage with the dataset "gnomad_r3_non_topmed" has no unexpected c
                         onClick={[Function]}
                         type="button"
                       >
-                        European
+                        Admixed American
                       </button>
                     </th>
                     <td
@@ -40764,7 +40764,7 @@ exports[`VariantPage with the dataset "gnomad_r3_non_topmed" has no unexpected c
                         onClick={[Function]}
                         type="button"
                       >
-                        Remaining
+                        Remaining individuals
                       </button>
                     </th>
                     <td
@@ -50308,7 +50308,7 @@ exports[`VariantPage with the dataset "gnomad_r3_non_v2" has no unexpected chang
                         onClick={[Function]}
                         type="button"
                       >
-                        Admixed American
+                        European (Finnish)
                       </button>
                     </th>
                     <td
@@ -50349,7 +50349,7 @@ exports[`VariantPage with the dataset "gnomad_r3_non_v2" has no unexpected chang
                         onClick={[Function]}
                         type="button"
                       >
-                        European
+                        Admixed American
                       </button>
                     </th>
                     <td
@@ -50636,7 +50636,7 @@ exports[`VariantPage with the dataset "gnomad_r3_non_v2" has no unexpected chang
                         onClick={[Function]}
                         type="button"
                       >
-                        Remaining
+                        Remaining individuals
                       </button>
                     </th>
                     <td
@@ -68168,7 +68168,7 @@ exports[`VariantPage with the dataset gnomad_r2_1 has no unexpected changes 1`]
                   onClick={[Function]}
                   type="button"
                 >
-                  Remaining
+                  Remaining individuals
                 </button>
               </th>
               <td
@@ -78173,7 +78173,7 @@ exports[`VariantPage with the dataset gnomad_r2_1_controls has no unexpected cha
                   onClick={[Function]}
                   type="button"
                 >
-                  Remaining
+                  Remaining individuals
                 </button>
               </th>
               <td
@@ -88178,7 +88178,7 @@ exports[`VariantPage with the dataset gnomad_r2_1_non_cancer has no unexpected c
                   onClick={[Function]}
                   type="button"
                 >
-                  Remaining
+                  Remaining individuals
                 </button>
               </th>
               <td
@@ -98183,7 +98183,7 @@ exports[`VariantPage with the dataset gnomad_r2_1_non_neuro has no unexpected ch
                   onClick={[Function]}
                   type="button"
                 >
-                  Remaining
+                  Remaining individuals
                 </button>
               </th>
               <td
@@ -108188,7 +108188,7 @@ exports[`VariantPage with the dataset gnomad_r2_1_non_topmed has no unexpected c
                   onClick={[Function]}
                   type="button"
                 >
-                  Remaining
+                  Remaining individuals
                 </button>
               </th>
               <td
diff --git a/dataset-metadata/gnomadPopulations.ts b/dataset-metadata/gnomadPopulations.ts
index d0e17884c..d36cda064 100644
--- a/dataset-metadata/gnomadPopulations.ts
+++ b/dataset-metadata/gnomadPopulations.ts
@@ -38,18 +38,18 @@ export const populationName = (populationId: string) =>
   textOrMissingTextWarning('genetic ancestry group name', GNOMAD_POPULATION_NAMES, populationId)
 
 const ExACPopulations: PopulationId[] = ['sas', 'afr', 'amr', 'eas', 'fin', 'nfe', 'remaining']
-const v2Populations: PopulationId[] = ['amr', 'nfe', 'afr', 'asj', 'eas', 'fin', 'sas', 'remaining']
+const v2Populations: PopulationId[] = ['amr', 'nfe', 'afr', 'asj', 'eas', 'fin', 'sas', 'oth']
 const v3Populations: PopulationId[] = [
   'nfe',
+  'fin',
   'amr',
-  'eur',
   'ami',
   'eas',
   'mid',
   'afr',
   'sas',
   'asj',
-  'remaining',
+  'oth',
 ]
 const v4Populations: PopulationId[] = [
   'afr',