Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading histogram average: ignores columns with nulls #9

Open
rodarima opened this issue Feb 27, 2023 · 1 comment
Open

Misleading histogram average: ignores columns with nulls #9

rodarima opened this issue Feb 27, 2023 · 1 comment

Comments

@rodarima
Copy link

rodarima commented Feb 27, 2023

When computing the aggregate statistics of an histogram showing the "% Time", the Average statistic is computed differently when there are no states for that object:

bad-histogram

You can see that the states 1 and 2 show the same value in Total and Average but not for 3. The "% Time" in the state 0 and 1 in CPU 0.1 should be 0 % not "-" (presumably null), so the Average values are divided by 2 instead of by 1.

I am unable to find any option to make Paraver show a 0 instead of converting it to null but I'm suspicious that this behavior is not intended in any case anyway.

Additionally, catching this with a large number of objects will be hard for the naked eye (when showing the totals only). As safety, could you also add the N being used to draw the average and the other statistics?

@rodarima
Copy link
Author

rodarima commented Mar 7, 2023

Here is a simple reproducer with the following trace:

#Paraver (19/01/38 at 03:14):00000000000000100_ns:0:1:1(2:1)
2:0:1:1:1:00:36:1
2:0:1:1:1:50:36:2
2:0:1:1:2:00:36:1

And here are the timeline and histogram:

bad-average

paraver-null-histogram-average.tar.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant