Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout when trying to get diff of two files #555

Open
calexander3 opened this issue Jan 3, 2024 · 10 comments
Open

Timeout when trying to get diff of two files #555

calexander3 opened this issue Jan 3, 2024 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@calexander3
Copy link

Hi there. I am getting a timeout when trying to compare these two files:
current_api.json
master_api.json

@calexander3
Copy link
Author

calexander3 commented Jan 4, 2024

It was working very reliably until Dec 14th at 3:17PM Eastern. After that, only a very small amount have succeeded. We send a hand full of requests per work day. Here are those files:
current_api-12-14.json
master_api-12-14.json

There is about 115k size difference between the working set and the failing set

@calexander3
Copy link
Author

We were able to trim some things for the purposes of the comparison. Less than ideal but it looks to be working again. But its REALLY close to the timeout.

current_api-1-5.json

@calexander3
Copy link
Author

It started happening again. Here is the latest file:
current_api-1-9.json

@paulRbr
Copy link
Member

paulRbr commented Jan 11, 2024

Hi @calexander3,

Thanks a lot for sharing some many details. We do have a long standing issue on our side for API documents that extensively use references ($ref). We are working actively on this to improve the support of references which should help (a lot) in terms of performance (and prevent from reaching the timeout limit that we have set to 30s and which is already way too high!).

Unfortunately I don't have a quick answer / solution for you right now but I'll be sure to let you know here when we release the ongoing work to improve reference management on our side.

Please hang tight 😊

@calexander3
Copy link
Author

That's very helpful information! I noticed we had some extra mime types that we don't need and those all container $ref. I removed them and it is around 20 seconds now

@blemke1971
Copy link

@paulRbr Here are the two files that seemed to be timing out from my standpoint.
ApplicationServicesApi.json
Branch_ApplicationServicesApi.json

@praveenm-symplr
Copy link

@paulRbr Is there any update on this issue? We started seeing this issue more frequently now!

@paulRbr paulRbr added the bug Something isn't working label Apr 13, 2024
@paulRbr
Copy link
Member

paulRbr commented Apr 13, 2024

Hi @praveenm-symplr,

Sorry for the long response time. We will release some important changes next week which should improve the timeouts. I will make sure to ping you folks on this issue as soon as our improvements are deployed in prod.

Hang tight 🤗

@praveenm-symplr
Copy link

@paulRbr Do we have any update on this?

@paulRbr
Copy link
Member

paulRbr commented Jul 23, 2024

Hi @praveenm-symplr,

Are you using the CLI to do public diffs? Or are you using it as an authenticated user of Bump.sh?
We are still having some performance issues for API documents with a lot of references ($ref) so that might be your case too.

Would you mind sending us an email to hello@bump.sh with the two API documents you are trying to diff which end up in timeout please? This will help us analyze the issue and get back to you faster.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants