Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model definition location #8

Open
topepo opened this issue Mar 27, 2021 · 3 comments
Open

model definition location #8

topepo opened this issue Mar 27, 2021 · 3 comments

Comments

@topepo
Copy link

topepo commented Mar 27, 2021

If you think that other packages might have engine definitions for gam_mod(), it would make sense to have the definition for that model live in parsnip and have the engines registered here.

@mdancho84
Copy link
Contributor

I agree - what do you think: if we first get the package up and running as 0.1.0, and then in version 0.2.0 we transition the definition to parsnip and retain the engines? Just thinking about a good transition plan that doesn't slow down the development.

@topepo
Copy link
Author

topepo commented Mar 29, 2021

I would do it before it goes to CRAN. We'd have to soft-deprecate the old version and it would just be easier to move it before it is "official"

@mdancho84
Copy link
Contributor

Hey @topepo We are back on gammodels (yes, we had one more name change). We'd like to begin the process of preparing the package for integration with parsnip. We can finalize the package on our end, but it sounds like you'd like the main gen_additive_mod() function to rest in parnsip. What's the best way to get started there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants